Change in vdsm[master]: hostdev: add support for usb devices

mpolednik at redhat.com mpolednik at redhat.com
Tue Apr 28 08:07:20 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for usb devices
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/39715/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3808:             # both addresses and determine the correct one.
Line 3809:             if hostdev.address_to_name(device_type, address) == device:
Line 3810:                 try:
Line 3811:                     address = self._getUnderlyingDeviceAddress(x, 1)
Line 3812:                 except IndexError:
> why wouldn't it have address? 
Second address: the "guest" address (libvirt does currently not report it) - https://bugzilla.redhat.com/show_bug.cgi?id=1211682
Line 3813:                     address = None
Line 3814: 
Line 3815:             known_device = False
Line 3816:             for dev in self.conf['devices']:


-- 
To view, visit https://gerrit.ovirt.org/39715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9b4f302353f3006e1f945dd342d351039ba387
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list