Change in vdsm[master]: virt: move libvirt helpers in a module

mpolednik at redhat.com mpolednik at redhat.com
Mon Apr 27 12:58:42 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: virt: move libvirt helpers in a module
......................................................................


Patch Set 23: Code-Review-1

On one side, +1 for something that needs to be done
on ther other side, I would like to discuss HOW this needs to be done. Mostly, how granular do we want to get - I see this an opportunity for bootstrapping 'libvirt' package with modules 'events' and 'domain'. This would give us namespacing such as libvirt.events.STRINGS or libvirt.domain.notifying (?) which imho is nicer.

-- 
To view, visit https://gerrit.ovirt.org/39332
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35ceeb12bc96bea12281ce9c9a1481342dd3afa9
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list