Change in vdsm[master]: stomp: server side subscriptions

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Apr 27 07:52:22 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: server side subscriptions
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/38451/15/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 120:         ack = frame.headers.get("ack", stomp.AckMode.AUTO)
Line 121:         subscription = stomp._Subscription(dispatcher.connection, destination,
Line 122:                                            sub_id, ack, None)
Line 123: 
Line 124:         # TODO make sure to cleanup when connection lost
> don't we want to address the TODO as part of this patch?
No, this is done in https://gerrit.ovirt.org/#/c/39969
Line 125:         self._sub_dests[destination].append(subscription)
Line 126:         self._sub_ids[sub_id] = subscription
Line 127: 
Line 128:     def _send_error(self, msg, connection):


-- 
To view, visit https://gerrit.ovirt.org/38451
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list