Change in vdsm[master]: detector: make sure to drop connection when no data

ybronhei at redhat.com ybronhei at redhat.com
Sun Apr 26 07:42:51 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: detector: make sure to drop connection when no data
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40172/2/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 104:                 return
Line 105:             dispatcher.handle_error()
Line 106:             return
Line 107: 
Line 108:         if monotonic_time() > self._give_up_at:
can't you use the has_expired function? and doesn't readable() function take care of this ?
Line 109:             self.log.debug("Timed out while waiting for data")
Line 110:             dispatcher.close()
Line 111:             return
Line 112: 


-- 
To view, visit https://gerrit.ovirt.org/40172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2fbb01a2e24b45f29c3fd77d00c3b4bb571687bf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list