Change in vdsm[master]: storage: exec mount in different cgroup

nsoffer at redhat.com nsoffer at redhat.com
Sat Apr 25 17:07:54 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: exec mount in different cgroup
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40179/2/vdsm/storage/mount.py
File vdsm/storage/mount.py:

Line 215:     def mount(self, mntOpts=None, vfstype=None, timeout=None):
Line 216:         # Always execute mount command in a different cgroup avoiding
Line 217:         # mounts using user space drivers like glusterfs to die on
Line 218:         # VDSM restart.
Line 219:         cmd = [constants.EXT_CGEXEC, '-g', 'cpu:/', constants.EXT_MOUNT]
> Tried with glusterfs - it seems to work.
Finally, we don't want glusterfs to run as root, so we should add --user=vdsm
Line 220: 
Line 221:         if vfstype is not None:
Line 222:             cmd.extend(("-t", vfstype))
Line 223: 


-- 
To view, visit https://gerrit.ovirt.org/40179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8dd6d6076af46ec3e2bf2400afb72ad8ec3fc3dd
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list