Change in vdsm[master]: vm: Use blockRebase if blockCopy is not supported

fromani at redhat.com fromani at redhat.com
Fri Apr 24 08:33:40 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm: Use blockRebase if blockCopy is not supported
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40158/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3582: 
Line 3583:             if drive.diskReplicate["diskType"] == DISK_TYPE.BLOCK:
Line 3584:                 flags |= libvirt.VIR_DOMAIN_BLOCK_REBASE_COPY_DEV
Line 3585: 
Line 3586:             self._dom.blockRebase(drive.name, base, flags=flags)
> I considered this, but it creates a method that you should never call. This
Makes fully sense to me.
Line 3587: 
Line 3588:     def _diskSizeExtendCow(self, drive, newSizeBytes):
Line 3589:         # Apparently this is what libvirt would do anyway, except that
Line 3590:         # it would fail on NFS when root_squash is enabled, see BZ#963881


-- 
To view, visit https://gerrit.ovirt.org/40158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03474e36d7e073b7e5924cb02f417e12d4ad75e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list