Change in vdsm[master]: systemd: set KillMode to process for vdsmd

sbonazzo at redhat.com sbonazzo at redhat.com
Thu Apr 23 14:19:29 UTC 2015


Sandro Bonazzola has posted comments on this change.

Change subject: systemd: set KillMode to process for vdsmd
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/40183/2/init/systemd/vdsmd.service.in
File init/systemd/vdsmd.service.in:

Line 19: User=@VDSMUSER@
Line 20: Group=@VDSMGROUP@
Line 21: PermissionsStartOnly=true
Line 22: TimeoutStopSec=@SERVICE_STOP_TIMEOUT@
Line 23: KillMode=process
> Is it safe enough to still kill all the other sub-process excluding gluster
ioprocess is killed by vdsm on sigterm, not by systemctl.
I've not digged into how vdsm terminate ioprocess but it should handle it cleanly
Line 24: 
Line 25: [Install]


-- 
To view, visit https://gerrit.ovirt.org/40183
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc0d7a6db7c59bbddbcd2a7dff8e2379802f51f5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Vijay Bellur <vbellur at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list