Change in vdsm[master]: events: vm status notifications
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Thu Apr 23 11:38:03 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
......................................................................
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38937/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1524: if not guestCpuLocked:
Line 1525: self._acquireCpuLockWithTimeout()
Line 1526: try:
Line 1527: self._guestCpuRunning = isRunning
Line 1528: if (not self._guestCpuRunning and
> dispatchLibvirtEvents()
Looking at the code of dispatchLibvirtEvents it looks like we use _onLibvirtLifecycleEvent to run hooks after VIR_DOMAIN_EVENT_STOPPED. There are status changes for VIR_DOMAIN_EVENT_SUSPENDED, VIR_DOMAIN_EVENT_RESUMED and VIR_DOMAIN_EVENT_ID_IO_ERROR_REASON but we have already covered them.
I do not see other places where we need to send event in dispatchLibvirtEvents. Can you please confirm my findings?
Line 1529: self._lastStatus in vmstatus.PAUSED_STATES):
Line 1530: self.cif.notify('|virt|VM_status|' + self.id,
Line 1531: **{self.id: 'Paused'})
Line 1532: finally:
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list