Change in vdsm[master]: storage: Remove validateStorageServerConnection

danken at redhat.com danken at redhat.com
Thu Apr 23 10:12:07 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: storage: Remove validateStorageServerConnection
......................................................................


storage: Remove validateStorageServerConnection

validateStorageServerConnection is inherently a racy (read: useless)
call, as a storage server may become unreachable an instant after
calling this method returns that it's OK.

This call has been progressively cut away over the past several
years:
 - Commit 1f608f9f73680c021fde4a14f432e6e91ac3f3f9 turned it into a
   noop call that returns 0 for any connection
 - Commit a1cdccdff54af7aea8de49c06d8535079cd78bff marked it as
   @deprecated

Since oVirt Engine stopped calling it in 3.3.0, now, in 3.6.0, we
can finally remove the call altogether. Note that this patch will make
new VDSM versions incompatible with oVirt Engine older than 3.3.0.

Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612
Bug-Url: https://bugzilla.redhat.com/730736
Signed-off-by: Allon Mureinik <amureini at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38230
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M client/vdsClient.py
M tests/vdsClientTests.py
M vdsm/API.py
M vdsm/rpc/BindingXMLRPC.py
M vdsm/rpc/Bridge.py
M vdsm/rpc/vdsmapi-schema.json
M vdsm/storage/hsm.py
7 files changed, 0 insertions(+), 169 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Allon Mureinik: Verified



-- 
To view, visit https://gerrit.ovirt.org/38230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1c0f3678005c4075098f134a628fef1f3fc8e612
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list