Change in vdsm[master]: vmdevices: move storage methods to storage module

fromani at redhat.com fromani at redhat.com
Wed Apr 22 13:17:44 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vmdevices: move storage methods to storage module
......................................................................


Patch Set 1:

I like the concept, but not yet 100% sure. it *is* storage-related code, it *must* be moved away from Vm class (and from vm.py), but not 100% sure this belongs under vmdevices/storage.py, because so far vmdevices/* contains device objects, not device conf/helpers.

It could be just matter of declaring that vmdevices/* can contain _also_ conf and helpers, however :)

-- 
To view, visit https://gerrit.ovirt.org/40133
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7b2db4ba7569ff0170a948b2954064c99c804a0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list