Change in vdsm[master]: python3: lib2to3.fixes.fix_idioms

danken at redhat.com danken at redhat.com
Wed Apr 22 11:01:01 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: python3: lib2to3.fixes.fix_idioms
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40125/2/lib/vdsm/ipwrapper.py
File lib/vdsm/ipwrapper.py:

Line 69: 
Line 70: 
Line 71: def equals(cls):
Line 72:     def __eq__(self, other):
Line 73:         return isinstance(other, cls) and self.__dict__ == other.__dict__
> This is incorrect - this test must succeeds when object.__class__ are the s
you are obviously right. That's what happens with positng auto-generated code :-(
Line 74:     cls.__eq__ = __eq__
Line 75:     return cls
Line 76: 
Line 77: 


-- 
To view, visit https://gerrit.ovirt.org/40125
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I543c07a9fefb592dc5f132453643eb8ac0808c63
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list