Change in vdsm[master]: vm.py: factor out device object creation from _run method

fromani at redhat.com fromani at redhat.com
Wed Apr 22 09:17:54 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm.py: factor out device object creation from _run method
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

I like the general direction and this patch makes the code a little nicer (to me), so I'm OK going ahead. Let's see how next patches will look.

https://gerrit.ovirt.org/#/c/40073/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 853:                 'index': 0,
Line 854:                 'truesize': 0})
Line 855:         return removables
Line 856: 
Line 857:     def buildDevicesFromMapping(self, devices):
> The way that code works is pure by design - only methodized it
yep, I meant fully de-methodizing it removing all 'self' references.
Line 858:         """
Line 859:         Given a device mapping, construct device objects in their internal
Line 860:         container
Line 861:         """


-- 
To view, visit https://gerrit.ovirt.org/40073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list