Change in vdsm[master]: Signs tests as broken due to wrong mocking

danken at redhat.com danken at redhat.com
Tue Apr 21 14:38:43 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Signs tests as broken due to wrong mocking
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40092/1/tests/samplingTests.py
File tests/samplingTests.py:

Line 151:         s1.operstate = 'x'
Line 152:         self.assertEquals('operstate:x', s1.connlog_diff(s0))
Line 153: 
Line 154:     # singing as broken as it tries to communicate libvirt
Line 155:     @brokentest
@brokentest("broken unless libvirtd is running")
Line 156:     @MonkeyPatch(libvirtconnection, '_read_password', read_password)
Line 157:     @ValidateRunningAsRoot
Line 158:     def testHostSampleReportsNewInterface(self):
Line 159:         hs_before = sampling.HostSample(os.getpid())


-- 
To view, visit https://gerrit.ovirt.org/40092
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib63293dde8bd8f7a5062151dff66b595025e5696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list