Change in vdsm[master]: Signs tests as broken due to wrong mocking

ybronhei at redhat.com ybronhei at redhat.com
Tue Apr 21 14:37:15 UTC 2015


Yaniv Bronhaim has uploaded a new change for review.

Change subject: Signs tests as broken due to wrong mocking
......................................................................

Signs tests as broken due to wrong mocking

Temporary solution to avoid broken uts:
Both testHostSampleReportsNewInterface
testHostSampleHandlesDisappearingVlanInterfaces try to communicate
libvirt using libvirtconnection - we should mock this calls and remove
the revert this patch.

Change-Id: Ib63293dde8bd8f7a5062151dff66b595025e5696
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M tests/samplingTests.py
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/92/40092/1

diff --git a/tests/samplingTests.py b/tests/samplingTests.py
index 959f767..d212870 100644
--- a/tests/samplingTests.py
+++ b/tests/samplingTests.py
@@ -151,6 +151,8 @@
         s1.operstate = 'x'
         self.assertEquals('operstate:x', s1.connlog_diff(s0))
 
+    # singing as broken as it tries to communicate libvirt
+    @brokentest
     @MonkeyPatch(libvirtconnection, '_read_password', read_password)
     @ValidateRunningAsRoot
     def testHostSampleReportsNewInterface(self):
@@ -163,6 +165,8 @@
             interfaces_diff = interfaces_after - interfaces_before
             self.assertEqual(interfaces_diff, set([dummy_name]))
 
+    # singing as broken as it tries to communicate libvirt
+    @brokentest
     @MonkeyPatch(libvirtconnection, '_read_password', read_password)
     @ValidateRunningAsRoot
     def testHostSampleHandlesDisappearingVlanInterfaces(self):


-- 
To view, visit https://gerrit.ovirt.org/40092
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib63293dde8bd8f7a5062151dff66b595025e5696
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list