Change in vdsm[master]: vm.py: factor out device object creation from _run method

fromani at redhat.com fromani at redhat.com
Tue Apr 21 13:29:40 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: vm.py: factor out device object creation from _run method
......................................................................


Patch Set 1:

(2 comments)

can you share more long term plans, to see the direction this patch is heading? To point to followup patches (if any) works anyway

https://gerrit.ovirt.org/#/c/40073/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 853:                 'index': 0,
Line 854:                 'truesize': 0})
Line 855:         return removables
Line 856: 
Line 857:     def buildDevicesFromMapping(self, devices):
does it make sense to make this a pure function?
Line 858:         """
Line 859:         Given a device mapping, construct device objects in their internal
Line 860:         container
Line 861:         """


Line 868:         """
Line 869:         Returns a map of {device type: [devices]} supplied in devices
Line 870:         section of conf.
Line 871: 
Line 872:         If devices section is missing, creait it according to the old API.
typo: "creait" vs "create"
Line 873: 
Line 874:         """
Line 875:         devices = self._makeDeviceDict()
Line 876: 


-- 
To view, visit https://gerrit.ovirt.org/40073
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c0d540988c05cd8dd1e13afca156dcc2cc6e81d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list