Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

fromani at redhat.com fromani at redhat.com
Tue Apr 21 09:55:20 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 26: Code-Review+1

(2 comments)

a couple of minor nits could be fixed later, so I'm for having this patch in

https://gerrit.ovirt.org/#/c/37509/26/lib/vdsm/constants.py.in
File lib/vdsm/constants.py.in:

Line 133: 
Line 134: EXT_NICE = '@NICE_PATH@'
Line 135: 
Line 136: EXT_PGREP = '@PGREP_PATH@'
Line 137: 
spurious line
Line 138: EXT_PYTHON = '@PYTHON@'
Line 139: 
Line 140: EXT_QEMUIMG = '@QEMUIMG_PATH@'
Line 141: 


https://gerrit.ovirt.org/#/c/37509/26/vdsm/v2v.py
File vdsm/v2v.py:

Line 213:         self._prepared_volumes = []
Line 214:         self._passwd_file = os.path.join(_V2V_DIR, "%s.tmp" % job_id)
Line 215: 
Line 216:     def start(self):
Line 217:         t = threading.Thread(target=self._run)
minor: "t" is maybe too terse, we usually try to avoid those names
Line 218:         t.daemon = True
Line 219:         t.start()
Line 220: 
Line 221:     @property


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 26
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list