Change in vdsm[master]: protocoldetector: Do not expose internals

danken at redhat.com danken at redhat.com
Tue Apr 21 09:50:00 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: protocoldetector: Do not expose internals
......................................................................


protocoldetector: Do not expose internals

Commit b25dbdcce4 (Have the protocol detector use the Reactor) exposed
the internals of the protocol acceptor to the detectors.

Previously detectors had a handleSocket() method, called to pass
ownership of the client socket to the detector.  The new code replaced
this with handle_dispatcher(), accepting a Dispatcher object.  The
detectors are now responsible for calling dispatcher.del_channel(),
removing the dispatcher from the event loop.

This patch changes the detector interface so detectors get the client
socket, and the protocol acceptor is maintaining the dispatcher.

Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39732
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/stompReactor.py
M tests/protocoldetectorTests.py
M vdsm/protocoldetector.py
M vdsm/rpc/BindingXMLRPC.py
4 files changed, 10 insertions(+), 15 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39732
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e7412919c21e93d47c2858f9076164778de0a5e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list