Change in vdsm[master]: protocoldetector: Fix next_check_interval

danken at redhat.com danken at redhat.com
Tue Apr 21 09:21:47 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: protocoldetector: Fix next_check_interval
......................................................................


protocoldetector: Fix next_check_interval

Commit b25dbdcce4 (Have the protocol detector use the Reactor) added the
check_next_interval() interface, returning the timeout until the next
check. However the implementation in some of the dispatchers was wrong,
always returning 0. This cause the event loop to run a busy polling loop
instead of waiting until the next dispatcher check time.

Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39994
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/sslutils.py
M vdsm/protocoldetector.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dima Kuznetsov: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/39994
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If7f71657df4baea22ade66dbda0a679aa4cb6832
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list