Change in vdsm[master]: Added support for iothreads

tjelinek at redhat.com tjelinek at redhat.com
Tue Apr 21 08:23:52 UTC 2015


Tomas Jelinek has posted comments on this change.

Change subject: Added support for iothreads
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/39796/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 2457: {'type': 'VmDiskDeviceSpecParams',
Line 2458:  'data': {'*path': 'str'
Line 2459:           '*ioTune': 'VmDiskDeviceIoTuneParams',
Line 2460:           '*pinToIoThread': 'uint'}}
Line 2461: 
> this change is fine, but numOfIoThreads was gone, and we still need it. Ple
yeah, right, restored
Line 2462: ##
Line 2463: # @VmDiskDeviceTuneParams:
Line 2464: #
Line 2465: # Extra parameters for VM disk devices. At least one


https://gerrit.ovirt.org/#/c/39796/7/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 362:                 driverAttrs['type'] = 'qcow2'
Line 363:             elif self.format:
Line 364:                 driverAttrs['type'] = 'raw'
Line 365: 
Line 366:             if hasattr(self, 'specParams') and \
> we usually prefer to write like
Done
Line 367:                'pinToIoThread' in self.specParams:
Line 368:                 driverAttrs['iothread'] = str(self.specParams['pinToIoThread'])
Line 369: 
Line 370:             driverAttrs['cache'] = self.cache


-- 
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list