Change in vdsm[master]: sslutils: move createSSLContext from clientIF

ykaplan at redhat.com ykaplan at redhat.com
Mon Apr 20 15:15:12 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: sslutils: move createSSLContext from clientIF
......................................................................


Patch Set 3:

(3 comments)

https://gerrit.ovirt.org/#/c/36699/3/lib/vdsm/sslutils.py
File lib/vdsm/sslutils.py:

Line 335:         if not self._is_handshaking:
Line 336:             self._handshake_finished_handler(dispatcher)
Line 337: 
Line 338: 
Line 339: def createSSLContext():
> As a library, it does not make sense to check the config and return None if
Done
Line 340:     sslctx = None
Line 341:     if config.getboolean('vars', 'ssl'):
Line 342:         truststore_path = config.get('vars', 'trust_store_path')
Line 343:         key_file = os.path.join(truststore_path, 'keys', 'vdsmkey.pem')


https://gerrit.ovirt.org/#/c/36699/3/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 166:                     cls._instance = clientIF(irs, log)
Line 167:         return cls._instance
Line 168: 
Line 169:     def _createAcceptor(self, host, port):
Line 170:         sslctx = sslutils.createSSLContext()
> Lets do:
Done
Line 171: 
Line 172:         self._acceptor = MultiProtocolAcceptor(host, port, sslctx)
Line 173: 
Line 174:     def createStompClient(self, connected_socket):


https://gerrit.ovirt.org/#/c/36699/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 26: import hooks
Line 27: import kaxmlrpclib
Line 28: from vdsm import utils
Line 29: from vdsm import vdscli
Line 30: from vdsm import sslutils
> not needed for this patch - bad rebase?
indeed.
Thanks,
will fix in next patch set.
Line 31: from vdsm.compat import pickle
Line 32: from vdsm.config import config
Line 33: from vdsm.define import NORMAL, errCode, Mbytes
Line 34: 


-- 
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list