Change in vdsm[master]: dnsmasqDhcp does not need to consider el6 anymore
osvoboda at redhat.com
osvoboda at redhat.com
Mon Apr 20 09:14:37 UTC 2015
Ondřej Svoboda has posted comments on this change.
Change subject: dnsmasqDhcp does not need to consider el6 anymore
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
There is no need for variables to carry constant values.
https://gerrit.ovirt.org/#/c/39536/2/tests/functional/networkTests.py
File tests/functional/networkTests.py:
Line 110: """
You can move the triple quotes to the end of the first line :-)
Line 115: dhcpv6_range_from, dhcpv6_range_to
Please just use the constants here.
--
To view, visit https://gerrit.ovirt.org/39536
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibb55bb609ca0ca60ce005257a5335d0a150f53d6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list