Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Apr 20 08:08:17 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/37509/25/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 409:     'Host_getConnectedStoragePools': {'ret': 'poollist'},
Line 410:     'Host_getDeviceList': {'ret': 'devList'},
Line 411:     'Host_getDevicesVisibility': {'ret': 'visible'},
Line 412:     'Host_getExternalVMs': {'ret': 'vmList'},
Line 413:     'Host_convertExternalVm': {},
We do not need this change when we do not return anything.
Line 414:     'Host_getHardwareInfo': {'ret': 'info'},
Line 415:     'Host_getLVMVolumeGroups': {'ret': 'vglist'},
Line 416:     'Host_getRoute': {'ret': 'info'},
Line 417:     'Host_getStats': {'ret': 'info'},


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list