Change in vdsm[master]: virt: support per-vm stats age

danken at redhat.com danken at redhat.com
Sun Apr 19 19:31:10 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: virt: support per-vm stats age
......................................................................


Patch Set 30:

(1 comment)

https://gerrit.ovirt.org/#/c/38066/30//COMMIT_MSG
Commit Message:

Line 7: virt: support per-vm stats age
Line 8: 
Line 9: For quite obscure historical reasons, VDSM marks
Line 10: a VM as unresponsive if stats are unavailable for too long.
Line 11: 
Assume that a VM was started, but it is tickled a qemu bug and never answer back. It must be marked as non-responsive, right?

Can you give an example of the unintentionally-changed behavior of Vdsm?

I'll probably need a face-to-face explanation of the issue.
Line 12: The benefit of this behaviour is questionable, but it was
Line 13: broken as side effect of the transition of new periodic,
Line 14: bulk sampling.
Line 15: 


-- 
To view, visit https://gerrit.ovirt.org/38066
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8cd75631c328aa380c10f1f6dd1a8075b2fe0ed
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list