Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
nsoffer at redhat.com
nsoffer at redhat.com
Sun Apr 19 14:32:32 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
......................................................................
Patch Set 25:
(4 comments)
https://gerrit.ovirt.org/#/c/37509/25/vdsm/API.py
File vdsm/API.py:
Line 1404: network: type, macAddr, bridge, dev
Line 1405: """
Line 1406: return v2v.get_external_vms(uri, username, password)
Line 1407:
Line 1408: def convertExternalVm(self, uri, username, password, vmProperties, jobId):
You must do the vmProperties -> vmInfo rename in all the files. See http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17998/console
Line 1409: return v2v.convert_external_vm(uri, username, password, vmProperties,
Line 1410: jobId, self._cif.irs)
Line 1411:
Line 1412: # Networking-related functions
https://gerrit.ovirt.org/#/c/37509/25/vdsm/rpc/BindingXMLRPC.py
File vdsm/rpc/BindingXMLRPC.py:
Line 366:
Line 367: def convertExternalVm(self, uri, username, password, vmProperties, jobId):
Line 368: api = API.Global()
Line 369: return api.convertExternalVm(uri, username, password, vmProperties,
Line 370: jobId)
Please update vmProperties -> vmInfo in all files. Consistency is important.
Line 371:
Line 372: def vmPause(self, vmId):
Line 373: vm = API.VM(vmId)
Line 374: return vm.pause()
https://gerrit.ovirt.org/#/c/37509/25/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 3813: # @password: libvirt connection password
Line 3814: #
Line 3815: # @vminfo: information of the VM such as name, id etc
Line 3816: #
Line 3817: # @jobId: Assign a UUID to this operation which can be used
Previously you had 3 lowercase parameters, and 2 mixedCase. Now that you are using vminfo, having jobId spoil the interface. Please rename jobId in all files to jobid.
Line 3818: # to identify it in @HostStats
Line 3819: #
Line 3820: # Since: 4.17.0
Line 3821: ##
https://gerrit.ovirt.org/#/c/37509/25/vdsm/v2v.py
File vdsm/v2v.py:
Line 339: self._proc.kill()
Line 340: except OSError as e:
Line 341: if e.errno != errno.ESRCH:
Line 342: logging.debug('Job %r virt-v2v process not running',
Line 343: self._id)
Here the error is *not* ESRCH, which means that process exists but you cannot kill it (e.g, EPERM).
This log should come bellow the raise line.
Line 344: raise
Line 345: else:
Line 346: logging.debug('Job %r virt-v2v process was killed',
Line 347: self._id)
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list