Change in vdsm[master]: stomp: parsing buffer refactoring

danken at redhat.com danken at redhat.com
Sat Apr 18 06:51:18 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: parsing buffer refactoring
......................................................................


stomp: parsing buffer refactoring

Refactored how we manage buffer and parser state in Parser class.
We have decided to drop dependency on cStringIO due to need of
searching which is not possible without converting.

Due to need for searching and required conversion this change makes
processing faster.


Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Signed-off-by: Saggi Mizrahi <smizrahi at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38666
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/yajsonrpc/stomp.py
1 file changed, 24 insertions(+), 18 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/38666
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list