Change in vdsm[master]: xmlrpc: fd leak fix

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Apr 17 06:42:53 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: xmlrpc: fd leak fix
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/39506/7//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-14 14:28:57 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-04-16 09:07:57 +0200
Line 6: 
Line 7: xmlrpc: fd leak fix
> This leak is in protocoldetector, not xmlrpc
I checked jsonrpc code and there is no leak there. Will change the name.
Line 8: 
Line 9: When running networkTests (xmlrpc) we noticed that each connection to
Line 10: vdsm leaks a fd. After the investigation we noticed that even that
Line 11: SSLSocket is closed the fd was not released. M2C releases fd by calling


Line 13: referece kept to a socket object. After further investigation it was
Line 14: clear that socket reference is hold by Dispatcher object.
Line 15: 
Line 16: There was an issue when we create new dispatcher and not pass map param
Line 17: socket_map is used instread. socket_map is never updated after initial
> instread -> instead
Done
Line 18: creating which creates ref leak.
Line 19: 
Line 20: 
Line 21: Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49


-- 
To view, visit https://gerrit.ovirt.org/39506
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list