Change in vdsm[master]: hsm: Add refreshDevice verb

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 16 21:20:01 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Add refreshDevice verb
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/38754/18/vdsm/storage/multipath.py
File vdsm/storage/multipath.py:

Line 97:         proc.wait(timeout)
Line 98:     finally:
Line 99:         if proc.returncode is None:
Line 100:             zombiereaper.autoReapPID(proc.pid)
Line 101:             raise Error("Timeout resizing device %r (pid=%s)"
> In both cases you're masking the exception of proc.wait. Is this really nec
Right, we should not mask proc.wait exceptions - it should not raise anything, but if we have a bug there, this will be very hard to debug.

I think we need:

    if proc.returncode is None:
        raise Error(...)

    if proc.returncode != 0:
        raise Error(...)

And this code is also used in hba.py - we have same issue there.
Line 102:                         % (guid, proc.pid))
Line 103:         if proc.returncode != 0:
Line 104:             stderr = proc.stderr.read(512)
Line 105:             raise Error("Error resizing device %r: %r"


-- 
To view, visit https://gerrit.ovirt.org/38754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbeec7920a7943a9b1ea9dbd93477fa9b642f5b
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list