Change in vdsm[master]: hsm: Report info needed for refreshing devices

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 16 20:10:12 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: hsm: Report info needed for refreshing devices
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/38675/7/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 1384: ##
Line 1385: {'type': 'BlockDevicePathInfo',
Line 1386:  'data': {'physdev': 'str', 'state': 'BlockDevicePathState',
Line 1387:           'lun': 'uint', 'deviceType': 'BlockDeviceType',
Line 1388:           'capacity': 'uint'}}
> I remember that in the really old days all the capacities in bytes were pas
We used 'str' in a previous version, and Adam asked to use 'uint' the reflect the real type. The code returns of course str, to be compatible with xmlrpc.
Line 1389: 
Line 1390: ##
Line 1391: # @IscsiSessionInfo:
Line 1392: #


https://gerrit.ovirt.org/#/c/38675/7/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 2027:                 pvsize = ""
Line 2028:                 vguuid = ""
Line 2029: 
Line 2030:             devInfo = {'GUID': dev.get("guid", ""), 'pvUUID': pvuuid,
Line 2031:                        'pvsize': str(pvsize),
> Ah it seems that you use a string indeed (but maybe I am missing something,
The uint means you have to convert this value to log on the engine side.
Line 2032:                        'vgUUID': vguuid, 'vendorID': dev.get("vendor", ""),
Line 2033:                        'productID': dev.get("product", ""),
Line 2034:                        'fwrev': dev.get("fwrev", ""),
Line 2035:                        "serial": dev.get("serial", ""),


-- 
To view, visit https://gerrit.ovirt.org/38675
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icfa5cf4321202362f5a00dad7c9a0347ba52ec71
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list