Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Thu Apr 16 14:44:55 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Make sure the \0 is a last char in the buffer
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/35938/14/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 252:         ndata = len(buf)
Line 253:         if ndata < (cl + 1):
Line 254:             return False
Line 255: 
Line 256:         if buf[cl] != "\0":
> why not buf.endswith("\0") ?
We could use endswith as well. Will update.
Line 257:             raise RuntimeError("Frame end is missing \\0")
Line 258: 
Line 259:         remainingBytes = 0
Line 260:         self._flush()


-- 
To view, visit https://gerrit.ovirt.org/35938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list