Change in vdsm[master]: sslutils: move createSSLContext from clientIF

ybronhei at redhat.com ybronhei at redhat.com
Thu Apr 16 12:04:26 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: sslutils: move createSSLContext from clientIF
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/36699/3/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 166:                     cls._instance = clientIF(irs, log)
Line 167:         return cls._instance
Line 168: 
Line 169:     def _createAcceptor(self, host, port):
Line 170:         sslctx = sslutils.createSSLContext()
> Lets do:
the ssl_protocol config also important here...
Line 171: 
Line 172:         self._acceptor = MultiProtocolAcceptor(host, port, sslctx)
Line 173: 
Line 174:     def createStompClient(self, connected_socket):


-- 
To view, visit https://gerrit.ovirt.org/36699
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8c7e324759892232d16a4913314f1dfa76ea85b8
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list