Change in vdsm[ovirt-3.5-gluster]: gluster: Fix arguments name for geo-replication status verb.
dnarayan at redhat.com
dnarayan at redhat.com
Thu Apr 16 10:14:14 UTC 2015
Hello Piotr Kliczewski, Dan Kenigsberg,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/39936
to review the following change.
Change subject: gluster: Fix arguments name for geo-replication status verb.
......................................................................
gluster: Fix arguments name for geo-replication status verb.
Fixed arguments name in apiwrapper and vdsmapi-gluster-schema
for geo-replication status verb.
Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14
Signed-off-by: Darshan N <dnarayan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39222
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/gluster/apiwrapper.py
M vdsm/rpc/vdsmapi-gluster-schema.json
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/39936/1
diff --git a/vdsm/gluster/apiwrapper.py b/vdsm/gluster/apiwrapper.py
index b1cfa95..37b7588 100644
--- a/vdsm/gluster/apiwrapper.py
+++ b/vdsm/gluster/apiwrapper.py
@@ -203,16 +203,16 @@
remoteUserName,
force)
- def geoRepSessionStatus(self, masterVolumeName, remoteHost,
+ def geoRepSessionStatus(self, volumeName, remoteHost,
remoteVolumeName, remoteUserName=None):
- return self._gluster.volumeGeoRepSessionStatus(masterVolumeName,
+ return self._gluster.volumeGeoRepSessionStatus(volumeName,
remoteHost,
remoteVolumeName,
remoteUserName)
- def geoRepSessionList(self, masterVolumeName=None, remoteHost=None,
+ def geoRepSessionList(self, volumeName=None, remoteHost=None,
remoteVolumeName=None, remoteUserName=None):
- return self._gluster.volumeGeoRepSessionList(masterVolumeName,
+ return self._gluster.volumeGeoRepSessionList(volumeName,
remoteHost,
remoteVolumeName,
remoteUserName)
diff --git a/vdsm/rpc/vdsmapi-gluster-schema.json b/vdsm/rpc/vdsmapi-gluster-schema.json
index 75ec865..9d8737f 100644
--- a/vdsm/rpc/vdsmapi-gluster-schema.json
+++ b/vdsm/rpc/vdsmapi-gluster-schema.json
@@ -1507,7 +1507,7 @@
# Since: 4.17.0
##
{'command': {'class': 'GlusterVolume', 'name': 'geoRepSessionStatus'},
- 'data': {'VolumeName': 'str', 'remoteHost': 'str',
+ 'data': {'volumeName': 'str', 'remoteHost': 'str',
'remoteVolumeName': 'str', '*remoteUserName': 'str'},
'returns': 'GlusterGeoRepSessionMap'}
--
To view, visit https://gerrit.ovirt.org/39936
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5-gluster
Gerrit-Owner: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
More information about the vdsm-patches
mailing list