Change in vdsm[master]: stomp: add an option to create a client

ybronhei at redhat.com ybronhei at redhat.com
Wed Apr 15 16:31:31 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: stomp: add an option to create a client
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

-1 for visibility - I want to hear your thoughts

https://gerrit.ovirt.org/#/c/38491/4/lib/yajsonrpc/stompReactor.py
File lib/yajsonrpc/stompReactor.py:

Line 168:     def get_local_address(self):
Line 169:         return self._socket.getsockname()[0]
Line 170: 
Line 171: 
Line 172: class StompClient(object):
Afaiu StompClient should remove when we use external broker, vdsm will only expose StompServer - so maybe exposing stompClient for cli should be separate from this class.. 


Pioter, am I right? 


Anyhow the reactor here is not required (hopefully I don't miss anything) - so you can create simple client only for the cli. If its too complex please say - but lets here what Pioter thinks first
Line 173:     log = logging.getLogger("jsonrpc.AsyncoreClient")
Line 174: 
Line 175:     def __init__(self, sock, reactor):
Line 176:         self._reactor = reactor


Line 172: class StompClient(object):
Line 173:     log = logging.getLogger("jsonrpc.AsyncoreClient")
Line 174: 
Line 175:     def __init__(self, sock, reactor):
Line 176:         self._reactor = reactor
_reactor is not in use. please remove in different patch
Line 177:         self._messageHandler = None
Line 178:         self._socket = sock
Line 179: 
Line 180:         self._aclient = stomp.AsyncClient(self, "vdsm")


-- 
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list