Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

fromani at redhat.com fromani at redhat.com
Wed Apr 15 13:45:52 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 23: Code-Review+1

(2 comments)

I'm confused about vdsClient dict VS {}, I trust the verification to resolve this (should be pretty easy).

Other than that looks good to me, no pending comments seem left, so here goes my +1

https://gerrit.ovirt.org/#/c/37509/23/client/vdsClient.py
File client/vdsClient.py:

Line 1916:                     print key + ': ' + str(val)
Line 1917: 
Line 1918:         return status['status']['code'], status['status']['message']
Line 1919: 
Line 1920:     def _parse_properties(self, properties):
ok, actually I missed this
Line 1921:         d = ast.literal_eval(properties)
Line 1922:         if type(d) != dict:
Line 1923:             raise ValueError("Invalid option %r" % properties)
Line 1924:         return d


Line 1930:         properties = self._parse_properties(args[3])
Line 1931:         job_id = args[4]
Line 1932: 
Line 1933:         validateArgTypes([uri, username, password, properties, job_id],
Line 1934:                          [str, str, str, dict, str], requiredArgsNumber=5)
Well, on one hand I don't want to delay this patch further for _this_ tiny bit, OTOH I understood from comments in patch v22 that '{}' works and 'dict' doesn't. I'm fine with whatever works.
Line 1935:         password = getAuthFromArgs(args, password)
Line 1936:         response = self.s.convertExternalVm(uri, username, password,
Line 1937:                                             properties, job_id)
Line 1938:         if response['status']['code'] != 0:


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list