Change in vdsm[master]: v2v: Convert VM from external source to Data Domain

fromani at redhat.com fromani at redhat.com
Wed Apr 15 11:18:50 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: Convert VM from external source to Data Domain
......................................................................


Patch Set 22:

(2 comments)

I was about to hit "+1", but I found a couple of minor issues inside. :(

https://gerrit.ovirt.org/#/c/37509/22/client/vdsClient.py
File client/vdsClient.py:

Line 1930:         properties = self._parse_properties(args[3])
Line 1931:         job_id = args[4]
Line 1932: 
Line 1933:         validateArgTypes([uri, username, password, properties, job_id],
Line 1934:                          [str, str, str, {}, str], requiredArgsNumber=5)
Are you sure it works with '{}'? I believe we need 'dict' here
Line 1935:         password = getAuthFromArgs(args, password)
Line 1936:         response = self.s.convertExternalVm(uri, username, password,
Line 1937:                                             properties, job_id)
Line 1938:         if response['status']['code'] != 0:


https://gerrit.ovirt.org/#/c/37509/22/vdsm/v2v.py
File vdsm/v2v.py:

Line 326:                     self._vm_properties['vmName']])
Line 327:         return cmd
Line 328: 
Line 329:     def abort(self):
Line 330:             self._status = STATUS.ABORTED
weird indentation
Line 331:             logging.info('Job %r aborting...', self._id)
Line 332:             self._abort()
Line 333: 
Line 334:     def _abort(self):


-- 
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list