Change in vdsm[master]: stomp: add an option to create a client

ykaplan at redhat.com ykaplan at redhat.com
Wed Apr 15 10:51:33 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: stomp: add an option to create a client
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/38491/4/vdsm/protocoldetector.py
File vdsm/protocoldetector.py:

Line 217:     def stop(self):
Line 218:         self.log.debug("Stopping Acceptor")
Line 219:         self._reactor.stop()
Line 220: 
Line 221:     def create_client(self, connected_socket, type):
> where is this going to be used?
jsonrpcvdscli.


We create a stomp client,
and then wrap it with jsonrpcclient

In the final patch in the series will eventually be used for the migration.
Line 222:         if type == "stomp":
Line 223:             for handler in self._handlers:
Line 224:                 if handler.NAME == "stomp":
Line 225:                     return handler.createClient(connected_socket)


-- 
To view, visit https://gerrit.ovirt.org/38491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list