Change in vdsm[master]: vdsm: Fix memory leak in netlink/link.py

danken at redhat.com danken at redhat.com
Wed Apr 15 09:31:45 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: Fix memory leak in netlink/link.py
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39416/1/lib/vdsm/netlink/link.py
File lib/vdsm/netlink/link.py:

Line 150:         _rtnl_link_put(link)
Line 151:         return link
Line 152: 
Line 153: 
Line 154: def _get_link(name=None, index=0, sock=None):
if this is made into a context manager, we can call put only in cases where the workaround was used.
Line 155:     """ If defined both name and index, index is primary """
Line 156:     # libnl/incluede/netlink/errno.h
Line 157:     NLE_INVAL = 7
Line 158:     NLE_NODEV = 31


-- 
To view, visit https://gerrit.ovirt.org/39416
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I883ce5f5c1ad0c0813d5d659de71761126a8fc80
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: John Taylor <jtt77777 at yahoo.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list