Change in vdsm[master]: migration: Use jsonrpc during migration of vms

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Wed Apr 15 09:23:11 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: migration: Use jsonrpc during migration of vms
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/36701/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 132:             client_socket = self._createSocket(port)
Line 133:             self._destServer = jsonrpcvdscli.connect(self._vm.cif,
Line 134:                                                      client_socket)
Line 135:             self.log.debug('Initiating connection with destination')
Line 136:             self._destServer.ping()
> This is the only way for us to check if connection was actually established
hmm..that's really weird....I'd expect that connect() actually connects to the other side. Meaning that if there's no one listening on the dst we fall back to xmlrpc and there's no need for an extra ping.
Line 137: 
Line 138:         except Exception:
Line 139:             if config.getboolean('vars', 'ssl'):
Line 140:                 self._destServer = vdscli.connect(


-- 
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list