Change in vdsm[master]: jsonrpc: raise JsonRpcError with meaningful message

dkuznets at redhat.com dkuznets at redhat.com
Tue Apr 14 11:03:35 UTC 2015


Dima Kuznetsov has posted comments on this change.

Change subject: jsonrpc: raise JsonRpcError with meaningful message
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39781/1/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 33:     def __init__(self, code, msg):
Line 34:         super(JsonRpcError, self).__init__(msg)
Line 35:         self.code = code
Line 36:         self.message = msg
Line 37:         super(RuntimeError, self).__init__(
This should be removed, base constructor should not be invoked twice
Line 38:             "[%d] %s" % (self.code, self.message)
Line 39:         )
Line 40: 
Line 41: 


-- 
To view, visit https://gerrit.ovirt.org/39781
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2900524c80e4b29487d2d6e10b6cf4eab77306c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list