Change in vdsm[master]: v2v: Convert VM from external source to Data Domain
nsoffer at redhat.com
nsoffer at redhat.com
Tue Apr 14 09:17:52 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: v2v: Convert VM from external source to Data Domain
......................................................................
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/37509/21/vdsm/v2v.py
File vdsm/v2v.py:
Line 337: try:
Line 338: self._proc.kill()
Line 339: except OSError as e:
Line 340: if e.errno != errno.ESRCH:
Line 341: raise
> ok
No. It should be like this (logging removed):
try:
kill
except OSError as e:
if e.errno != errno.ESRCH:
raise
finally:
pass pid to zombie reaper
Why?
- We are not interested in the return code
- We want to reap zombies
- We do not handle errors we don't know how to handle
Line 342: logging.debug('Job %r virt-v2v process is not running'
Line 343: ' (pid: %d)', self._id, self._proc.pid)
Line 344: finally:
Line 345: if not self._proc.wait(timeout=self.PROC_WAIT_TIMEOUT):
--
To view, visit https://gerrit.ovirt.org/37509
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bd86d5a87ea8c42113c4a732f87ddd4ceab9ea
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list