Change in vdsm[master]: Added support for iothreads

tjelinek at redhat.com tjelinek at redhat.com
Tue Apr 14 08:50:34 UTC 2015


Tomas Jelinek has posted comments on this change.

Change subject: Added support for iothreads
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/39796/2/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:

Line 3588:           '*smpCoresPerSocket': 'uint', '*smpThreadsPerCore': 'uint',
Line 3589:           'status': 'VmStatus', 'timeOffset': 'uint',
Line 3590:           'transparentHugePages': 'bool', 'vmId': 'UUID', 'vmName': 'str',
Line 3591:           'vmType': 'VmType', '*exitCode': 'int', '*exitMessage': 'str',
Line 3592:           '*serial': 'str', 'numOfIoThreads': 'str'}}
> ok - will fix that
Done
Line 3593: 
Line 3594: ##
Line 3595: # @VmParameters:
Line 3596: #


https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 827:         # the numOfIoThreads has to be passed to the specific disks
Line 828:         # so they can set the pinning up
Line 829:         if 'numOfIoThreads' in self.conf:
Line 830:             if drv['type'] == 'disk' and drv['iface'] == 'virtio':
Line 831:                 drv['numOfIoThreads'] = self.conf['numOfIoThreads']
> As tempting as is option #2, I'm inclined toward option #1 above (be carefu
ok, done
Line 832: 
Line 833:     def __legacyDrives(self):
Line 834:         """
Line 835:         Backward compatibility for qa scripts that specify direct paths.


https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 365: 
Line 366:             if self.iface == 'virtio' and hasattr(self, 'numOfIoThreads'):
Line 367:                 i = int(self.index)
Line 368:                 pinToThread = i % self.numOfIoThreads + 1
Line 369:                 driverAttrs['iothread'] = str(pinToThread)
> please look at comment in vm.py
ok, so moved to vm.py
Line 370: 
Line 371:             driverAttrs['cache'] = self.cache
Line 372: 
Line 373:             if (self.propagateErrors == 'on' or


https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 162: 
Line 163:         self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164:         self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165:         if 'numOfIoThreads' in self.conf:
Line 166:             ioThreads = self.conf['numOfIoThreads']
> ok, I will break it up
Done
Line 167:             self.dom.appendChildWithArgs('iothreads', text=str(ioThreads))
Line 168:         memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169:         self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170:         self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)


-- 
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list