Change in vdsm[master]: virt: add unit test for getUnderlying* family of methods

fromani at redhat.com fromani at redhat.com
Tue Apr 14 07:03:58 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: add unit test for getUnderlying* family of methods
......................................................................


Patch Set 2:

(1 comment)

nice work

https://gerrit.ovirt.org/#/c/39364/2/tests/devices/parsing/complex_vm_tests.py
File tests/devices/parsing/complex_vm_tests.py:

Line 1: import os
missing copyright boilerplate. IANAL, and for this very reason I want to play it safe :)
Line 2: 
Line 3: from testlib import XMLTestCase
Line 4: 
Line 5: from virt import domain_descriptor


-- 
To view, visit https://gerrit.ovirt.org/39364
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If202340d8f26cb79d2a8d306a114cd6dc39dada0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list