Change in vdsm[master]: Added support for iothreads

fromani at redhat.com fromani at redhat.com
Mon Apr 13 11:11:19 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: Added support for iothreads
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/39796/2/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 162: 
Line 163:         self.dom.appendChildWithArgs('name', text=self.conf['vmName'])
Line 164:         self.dom.appendChildWithArgs('uuid', text=self.conf['vmId'])
Line 165:         if 'numOfIoThreads' in self.conf:
Line 166:             ioThreads = self.conf['numOfIoThreads']
> we don't need this temporary
hit 'done' too fast. Besides the temporary, this code looks fine. It is just the pinning between iothreads and drives that should be changed.
Line 167:             self.dom.appendChildWithArgs('iothreads', text=str(ioThreads))
Line 168:         memSizeKB = str(int(self.conf.get('memSize', '256')) * 1024)
Line 169:         self.dom.appendChildWithArgs('memory', text=memSizeKB)
Line 170:         self.dom.appendChildWithArgs('currentMemory', text=memSizeKB)


-- 
To view, visit https://gerrit.ovirt.org/39796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I576e5af72869ac03d09bdc2d6e6f16d5b06b5aed
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list