Change in vdsm[master]: jsonrpcvdscli: create a client for vdsm with jsonrpc

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Apr 13 10:31:25 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: create a client for vdsm with jsonrpc
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/39203/2/lib/vdsm/jsonrpcvdscli.py
File lib/vdsm/jsonrpcvdscli.py:

Line 62:     def migrationCreate(self, params):
Line 63:         self._callMethod(command_converter['migrationCreate'],
Line 64:                          params['vmId'],
Line 65:                          params)
Line 66:         return {'status': {'code': 0}}
Please use status from the _callMethod response
Line 67: 
Line 68:     def __getattr__(self, methodName):
Line 69:         return partial(self._callMethod(methodName))
Line 70: 


-- 
To view, visit https://gerrit.ovirt.org/39203
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9dbd70d28968db1305628281015f7b2379c8058
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list