Change in vdsm[master]: functional tests: add basic device verification

ibarkan at redhat.com ibarkan at redhat.com
Mon Apr 13 06:52:31 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: functional tests: add basic device verification
......................................................................


Patch Set 7: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/38980/7/tests/verify.py
File tests/verify.py:

Line 20: 
Line 21: from virt.vmdevices import hwclass
Line 22: 
Line 23: 
Line 24: class DeviceMixin(object):
this class as it is now (simple and clean) can be reduced into a single verifyDevicesConf method that is a member of TestVmDevicesXmlParsing.
Line 25:     """
Line 26:     Mixin that extends *TestCase class with method to verify device parsing
Line 27:     from libvirt XML.
Line 28:     """


-- 
To view, visit https://gerrit.ovirt.org/38980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88ca6630ad047fbc1d9b036e1112bf5db41dc24d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list