Change in vdsm[master]: network: support PCI passthrough of SR-IOV network interfaces.

ibarkan at redhat.com ibarkan at redhat.com
Mon Apr 13 06:21:39 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: support PCI passthrough of SR-IOV network interfaces.
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/38249/12/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 111:             vlan.appendChildWithArgs('tag', id=str(self.vlanId))
Line 112: 
Line 113:         return interface
Line 114: 
Line 115:     def _add_source_pci_address(self, parent_element, type=None):
> This is a lie: we're adding source address, nothing says that it is PCI. Re
Done
Line 116:         parent_element.appendChildWithArgs('address', type=type,


-- 
To view, visit https://gerrit.ovirt.org/38249
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib962fbf1bb08cd5b82b649cc05612471e4e4d0b8
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list