Change in vdsm[ovirt-3.5]: multipath: Wait for udev events after rescan

ybronhei at redhat.com ybronhei at redhat.com
Sun Apr 12 16:30:49 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: multipath: Wait for udev events after rescan
......................................................................


multipath: Wait for udev events after rescan

Previously we were using time.sleep(2) for waiting at least 2 seconds
after starting iSCSI sessions rescan. This wait was useless for two
reasons:
- The sleep was interrupted as soon as iscsiadm process terminated
- Udev events generated by the SCSI scan and by processing udev rules
  may not been handled yet when iscsiadm existed.

This patch replaces the minimal scsi timeout with udevadm.settle(),
waiting until current udev events are handled.  Since we perform both FC
and iSCSI scan, the correct place for waiting is in multipath.rescan()
and not in iscsi.rescan().

A new configuration was introduced, allowing fine tuning of settle
timeout in the field.

    [irs]
    scsi_settle_timeout = 5

Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Bug-Url: https://bugzilla.redhat.com/1209028
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39288
Reviewed-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Tested-by: Douglas Schilling Landgraf <dougsland at redhat.com>
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/39606
Tested-by: Ala Hino <ahino at redhat.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/storage/iscsi.py
M vdsm/storage/multipath.py
3 files changed, 17 insertions(+), 25 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, approved
  Allon Mureinik: Looks good to me, but someone else must approve
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/39606
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieeffbdd447e96c4ec92b829388da1dc6222a2dae
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list