Change in vdsm[master]: sp: Add resizePV verb

frolland at redhat.com frolland at redhat.com
Sun Apr 12 10:11:32 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: sp: Add resizePV verb
......................................................................


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/39382/10/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:

Line 771:         :type sdUUID: UUID
Line 772:         :param spUUID: The UUID of the storage pool that owns the PV.
Line 773:         :type spUUID: UUID
Line 774:         :param guid: A block device GUID
Line 775:         :type guid: UUID
> UUID -> str
Done
Line 776:         :param options: unused
Line 777:         :returns: dictionary with one item :size
Line 778:         :rtype: dict
Line 779:         """


https://gerrit.ovirt.org/#/c/39382/10/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:

Line 873:     changes it is needed to resize the PV after the multipath devices have
Line 874:     been resized
Line 875: 
Line 876:     Raises se.CouldNotResizePhysicalVolume if pvresize fails
Line 877: 
> Remove empty line
Done
Line 878:     """
Line 879:     pvName = _fqpvname(guid)
Line 880:     cmd = ["pvresize", pvName]
Line 881:     rc, out, err = _lvminfo.cmd(cmd, (pvName,))


-- 
To view, visit https://gerrit.ovirt.org/39382
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57e0fe4fad3e41cd6346b49623869c6d26afaa92
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list