Change in vdsm[master]: stomp: make subscription class local

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Apr 10 12:50:35 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: make subscription class local
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38990/2/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 366:         return None
Line 367: 
Line 368:     def put_subscribe(self, destination, ack=None):
Line 369:         subid = self._aclient.subscribe(self._adisp, destination, ack)
Line 370:         sub = _Subsciption(self, subid, ack)
> do we want to keep this typo?
Will fix.
Line 371:         self._registerSubscription(sub)
Line 372:         return sub
Line 373: 
Line 374:     def put_send(self, destination, data="", headers=None):


-- 
To view, visit https://gerrit.ovirt.org/38990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabe55399860e92e7a0a41feba9879a8b82d5c786
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list