Change in vdsm[master]: stomp: reserve space for Frame instance variables

fromani at redhat.com fromani at redhat.com
Fri Apr 10 08:37:48 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: stomp: reserve space for Frame instance variables
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/39722/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-04-09 10:27:40 +0200
Line 4: Commit:     pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-04-09 10:27:40 +0200
Line 6: 
Line 7: stomp: reserve space for Frame instance variables
Please note that the comment here may be misleading.
Maybe it's just me, but one can read this line as "make sure there is enough space", while the whole point of using __slots__ is to reduce the space waste to the minimum ("make sure we use the minimum space")

https://docs.python.org/2/reference/datamodel.html#slots

So, we expect to have huge number of Frames around, right? Maybe worth point this out in the commit message.
Line 8: 
Line 9: 
Line 10: Change-Id: Iefa5202398e6b5d8af6c62aebcd07ef056b681a9


-- 
To view, visit https://gerrit.ovirt.org/39722
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefa5202398e6b5d8af6c62aebcd07ef056b681a9
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list