Change in vdsm[master]: tests: reduce noice after running detector test

nsoffer at redhat.com nsoffer at redhat.com
Thu Apr 9 14:37:56 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: tests: reduce noice after running detector test
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/39031/6//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: tests: reduce noice after running detector test
Line 8: 
Line 9: We need to make sure that all the resources are closed properly during
Line 10: tear down. We want to check whether the tests pass using m2c and
> We are not testing ssl module nor m2c so why favor one over the other?
Because ssl is in stdlib, we can safely depend on it.
Line 11: standard ssl module. As well as we want to get rid of AttributeError
Line 12: while interpreter shutdown after running test suite.
Line 13: 
Line 14: 


Line 8: 
Line 9: We need to make sure that all the resources are closed properly during
Line 10: tear down. We want to check whether the tests pass using m2c and
Line 11: standard ssl module. As well as we want to get rid of AttributeError
Line 12: while interpreter shutdown after running test suite.
> When we do not close a socket it is closed during interpreter shutdown and 
So you think that we have a detector thread that is still running when the test ends?
Line 13: 
Line 14: 
Line 15: Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80


-- 
To view, visit https://gerrit.ovirt.org/39031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list